Changeset 159e7df for app/Http

Timestamp:

10/24/21 21:42:47 (3 years ago)

Author:

beratkjufliju <kufliju@…>

Branches:

develop, master

Children:

169fcc8

Parents:

1c17e70

Message:

bug fixes

Location:

app/Http/Controllers/Dashboard

Files:

• DepartmentsController.php (modified) (2 diffs)
• FoldersController.php (modified) (2 diffs)

app/Http/Controllers/Dashboard/DepartmentsController.php

@@ -124 +124 @@
         $zip->open($zip_file, \ZipArchive::CREATE | \ZipArchive::OVERWRITE);
         $path = Storage::disk('uploads')->path('Departments');
-        $files = new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($path));
-        $flag=false;
 
-        foreach ($files as $file)
-        {
-            if(File::all()->count() > 0) {
+        try {
+            $files = new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($path));
+            $flag = false;
 
-                // We're skipping all subfolders
-                if (!$file->isDir()) {
-                    $filePath = $file->getRealPath();
-                    // extracting filename with substr/strlen
-                    $relativePath = substr($filePath, strlen($path) + 1);
-                    $zip->addFile($filePath, $relativePath);
+            foreach ($files as $file) {
+
+                    // We're skipping all subfolders
+                    if (!$file->isDir()) {
+                        $filePath = $file->getRealPath();
+                        // extracting filename with substr/strlen
+                        $relativePath = substr($filePath, strlen($path) + 1);
+                        $zip->addFile($filePath, $relativePath);
+                    }
                 }
-            }
-            else
-            {
-                $flag=true;
-            break;
-            }
+                $zip->close();
+                $headers = array('Content-Type' => 'application/octet-stream');
+                $zip_new_name = Carbon::now()->format('d.m.Y - H:i') . '- Departments.zip';
+                return response()->download($zip_file, $zip_new_name, $headers);
         }
-        if(!$flag) {
-            $zip->close();
-            $headers = array('Content-Type' => 'application/octet-stream');
-            $zip_new_name = Carbon::now()->format('d.m.Y - H:i') . '- Departments.zip';
-            return response()->download($zip_file, $zip_new_name, $headers);
-        }
-        else {
-            Alert::flash("All departments are empty", "warning");
+        catch(\Exception $e){
+           Alert::flash("All departments are empty", "warning");
             return redirect()->back();
         }
@@ -166 +159 @@
         $zip->open($zip_file, \ZipArchive::CREATE | \ZipArchive::OVERWRITE);
         $path = Storage::disk('uploads')->path($department->location) . DIRECTORY_SEPARATOR;
-        $files = new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($path));
 
-        $filesInDept = $FileSystem->allFiles($path);
-
-        if(!empty($filesInDept)) {
-        foreach ($files as $file) {
-            if (!$file->isDir()) {
-                $filePath = $file->getRealPath();
-                // extracting filename with substr/strlen
-                $relativePath = substr($filePath, strlen($path) + 1);
-                $zip->addFile($filePath, $relativePath);
-            }
+        try{
+            $files = new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($path));
+            foreach ($files as $file) {
+                if (!$file->isDir()) {
+                    $filePath = $file->getRealPath();
+                    // extracting filename with substr/strlen
+                    $relativePath = substr($filePath, strlen($path) + 1);
+                    $zip->addFile($filePath, $relativePath);
+                }
+            $zip->close();
+            $headers = array('Content-Type' => 'application/octet-stream',);
+            $zip_new_name = Carbon::now()->format('d.m.Y - H:i') . $department->name . '.zip';
+            return response()->download($zip_file, $zip_new_name, $headers);
         }
-        $zip->close();
-        $headers = array('Content-Type' => 'application/octet-stream',);
-            $zip_new_name = Carbon::now()->format('d.m.Y - H:i') . $department->name . '.zip';
-        return response()->download($zip_file, $zip_new_name, $headers);
-        }
-        else{
+    }
+    catch(\Exception $e) {
             Alert::flash("This department has no files", "warning");
             return redirect()->back();
-        }
-
+    }
     }
 }

app/Http/Controllers/Dashboard/FoldersController.php

@@ -284 +284 @@
         $path = Storage::disk('uploads')->path($folder->department->location . DIRECTORY_SEPARATOR . $folder->name);
 
-        $files = new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($path));
-
-        $filesInDoc = $FileSystem->allFiles($path);
-
-        if(empty(!$filesInDoc)) {
+        try {
+            $files = new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($path));
+
+            $filesInDoc = $FileSystem->allFiles($path);
+
             foreach ($files as $file) {
                 if (!$file->isDir()) {
@@ -300 +300 @@
             $headers = array('Content-Type' => 'application/octet-stream',);
             $zip_new_name = Carbon::now()->format('d.m.Y - H:i') . $folder->name . '.zip';
-                return response()->download($zip_file, $zip_new_name, $headers);
-        }
-        else {
+            return response()->download($zip_file, $zip_new_name, $headers);
+        }
+        catch (\Exception $e) {
             Alert::flash("This folder has no files", "warning");
             return redirect()->back();
         }
-
     }