Changeset 94f05dc for app

Timestamp:

10/24/21 23:23:54 (3 years ago)

Author:

beratkjufliju <kufliju@…>

Branches:

develop, master

Children:

df6e9ec

Parents:

fa80fbe

Message:

bug fixes

Location:

app/Http

Files:

• Controllers/Dashboard/DepartmentsController.php (modified) (4 diffs)
• Controllers/Dashboard/FoldersController.php (modified) (1 diff)
• Requests/Dashboard/FolderRequest.php (modified) (2 diffs)

app/Http/Controllers/Dashboard/DepartmentsController.php

@@ -47 +47 @@
 
         $users = User::all();
-        Notification::send($users, new NewDepartmentCreated("New department created"));
 
         $department->save();
@@ -127 +126 @@
         try {
             $files = new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($path));
-            $flag = false;
-
             foreach ($files as $file) {
 
@@ -154 +151 @@
         $department = Department::find($id);
 
-        $FileSystem = new Filesystem();
-        $zip_file = Storage::disk('uploads')->path('Department.zip');
+        $zip_file=Storage::disk('uploads')->path('Department.zip');
         $zip = new \ZipArchive();
         $zip->open($zip_file, \ZipArchive::CREATE | \ZipArchive::OVERWRITE);
-        $path = Storage::disk('uploads')->path($department->location) . DIRECTORY_SEPARATOR;
+        $path = Storage::disk('uploads')->path($department->location);
 
-        try{
+        try {
             $files = new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($path));
             foreach ($files as $file) {
+
+                // We're skipping all subfolders
                 if (!$file->isDir()) {
                     $filePath = $file->getRealPath();
@@ -169 +167 @@
                     $zip->addFile($filePath, $relativePath);
                 }
+            }
             $zip->close();
-            $headers = array('Content-Type' => 'application/octet-stream',);
-            $zip_new_name = Carbon::now()->format('d.m.Y - H:i') . $department->name . '.zip';
+            $headers = array('Content-Type' => 'application/octet-stream');
+            $zip_new_name = Carbon::now()->format('d.m.Y - H:i') . '- Departments.zip';
             return response()->download($zip_file, $zip_new_name, $headers);
         }
-    }
-    catch(\Exception $e) {
-            Alert::flash("This department has no files", "warning");
+        catch(\Exception $e){
+            Alert::flash("All departments are empty", "warning");
             return redirect()->back();
-    }
+        }
     }
 }

app/Http/Controllers/Dashboard/FoldersController.php

@@ -163 +163 @@
         Alert::flash("New folder created successfully");
 
-        return redirect()->back();
+        return redirect()->route("dashboard.folders.index");
     }
 

app/Http/Requests/Dashboard/FolderRequest.php

@@ -41 +41 @@
                         $arch_id = $this->request->get('arch_id');
 
-                        $deptId = explode('/', $arch_id)[0];
+                        $deptCode = explode('/', $arch_id)[0];
                         $archNum = explode('/', $arch_id)[1];
 
@@ -48 +48 @@
                         }
 
-                        if ($deptId !== Department::find($this->request->get('department'))->code) {
+                        if ($deptCode != Department::find($this->request->get('department'))->code) {
                             $fail("Folder Archive ID field format is invalid");
                         }
-                    } catch (\Exception $e) {
+                    }
+                    catch (\Exception $e) {
                         $fail("Please enter folders Archive ID");
                     }