Changeset bd9e8e3 for app

Timestamp:

10/17/21 20:28:35 (3 years ago)

Author:

Berat Kjufliju <kufliju@…>

Branches:

develop, master

Children:

e6c1f87

Parents:

d795fa6

Message:

added arch_id validation

Location:

app/Http

Files:

• Controllers/Dashboard/DocumentsController.php (modified) (4 diffs)
• Controllers/Dashboard/SettingsController.php (modified) (2 diffs)
• Requests/Dashboard/DocumentRequest.php (modified) (3 diffs)
• Requests/Dashboard/UsernameSettingsRequest.php (modified) (2 diffs)

app/Http/Controllers/Dashboard/DocumentsController.php

@@ -17 +17 @@
     public function index(Request $request)
     {
-        if($request->department) {
-            $documents = Document::with('department')->where('department', function ($query) {
-                $query->where('id', $request->department)->get();
-            });
-        }
-        else{
+        if ($request->query('id')) {
+            $documents = Document::where('department_id', $request->query('id'))->get();
+        } else {
             $documents = Document::all();
         }
@@ -68 +65 @@
         $document->arch_id = $request->arch_id;
         $document->description = $request->description;
-        $document->updated_at = $request->Carbon::now();;
 
         $document->save();
@@ -90 +86 @@
         $document->description = $request->description;
 
-        if(!Storage::disk('local')->has($document->department()->pluck('location')->join("") . '/' . $request->arch_id)){
+        if (!Storage::disk('local')->has($document->department()->pluck('location')->join("") . '/' . $request->arch_id)) {
             Storage::disk('local')->makeDirectory($document->department()->pluck('location')->join("") . '/' . $request->arch_id);
         }
@@ -106 +102 @@
         }
 
-            Alert::flash("New document created successfully");
+        Alert::flash("New document created successfully");
 
         return redirect()->route("dashboard.documents.index");

app/Http/Controllers/Dashboard/SettingsController.php

@@ -18 +18 @@
             "user" => auth()->user(),
             "adminAndEditors" => User::where("role_id", 1)->orWhere("role_id", 2)->get(),
+            "active_tab" => "account"
         ]);
     }
@@ -23 +24 @@
     public function updateUsername(UsernameSettingsRequest $request)
     {
-//        if($request->validated()){
-//        $user = auth()->user();
-//        $user->username = $request->username;
-//        $user->save();
-//
-//        auth()->logout();
-//        session()->flush();
-//
-//        return redirect()->route("auth.loginShow");
-//        }
-//        else {
-            return back()->withInput(['tab'=>'security']);
-       // }
+        if ($request->validated()) {
+            $user = auth()->user();
+            $user->username = $request->username;
+            $user->save();
+
+            auth()->logout();
+            session()->flush();
+
+            return redirect()->route("auth.loginShow");
+        } else {
+            return back()->with(['active_tab' => 'security']);
+        }
+
+        dd('no');
     }
 

app/Http/Requests/Dashboard/DocumentRequest.php

@@ -16 +16 @@
     public function authorize()
     {
-        if($this->isMethod("patch")) {
+        if ($this->isMethod("patch")) {
             $document = Document::find($this->route("id"));
             return auth()->user()->hasPermission("edit_all_documents") || ($document->user->id == auth()->user()->id);
@@ -33 +33 @@
 
         $rules = [
-            "arch_id" => "required|min:10|max:255",
+            "arch_id" => [
+                "required",
+                function($attribute, $value, $fail) {
+                    $arch_id = $this->request->get('arch_id');
+                    $deptId = explode('/', $arch_id)[0];
+                    if ($deptId !== $this->request->get('department')) {
+                        $fail("Dept id error");
+                    }
+                }
+            ],
             "name" => "required|min:10|max:255",
             "department" => "required|integer|exists:departments,id",
@@ -39 +48 @@
         ];
 
-        if($this->isMethod("patch")) {
+        if ($this->isMethod("patch")) {
             $fileRules = [
                 "file_item.*" => "mimes:jpg,jpeg,png|max:4096"
-                ];
+            ];
         } else {
             $fileRules = [

app/Http/Requests/Dashboard/UsernameSettingsRequest.php

@@ -4 +4 @@
 
 use Illuminate\Foundation\Http\FormRequest;
+use Illuminate\Contracts\Validation\Validator;
+use Illuminate\Validation\ValidationException;
 
 class UsernameSettingsRequest extends FormRequest
@@ -28 +30 @@
         ];
     }
+
+    protected function failedValidation(Validator $validator)
+    {
+        $response = redirect()
+            ->route('dashboard.settings.index')
+            ->with(['active_tab' => 'security'])
+            ->withErrors($validator);
+
+        throw (new ValidationException($validator, $response))
+            ->errorBag($this->errorBag)
+            ->redirectTo($this->getRedirectUrl());
+    }
 }