Changeset 0808ef2

Timestamp:

02/10/26 13:53:31 (5 months ago)

Author:

Filip Gavrilovski <filipgavrilovski28@…>

Branches:

main

Children:

1579b4f

Parents:

890e036

Message:

fix bug that prevented nonauthenticated users from searching and accessing user and album pages

Location:

finkwave/src/main/java/com/ukim/finki/develop/finkwave

Files:

• controller/UserController.java (modified) (1 diff)
• service/AlbumService.java (modified) (2 diffs)
• service/ArtistService.java (modified) (1 diff)
• service/AuthService.java (modified) (2 diffs)
• service/FollowService.java (modified) (1 diff)
• service/NonAdminUserService.java (modified) (3 diffs)
• service/PlaylistService.java (modified) (1 diff)
• service/SongService.java (modified) (2 diffs)

finkwave/src/main/java/com/ukim/finki/develop/finkwave/controller/UserController.java

@@ -32 +32 @@
         return ResponseEntity.ok(usersService.search(userType, searchTerm, limit));
     }
+
 }

finkwave/src/main/java/com/ukim/finki/develop/finkwave/service/AlbumService.java

@@ -26 +26 @@
             throw new AlbumNotFoundException(id);
         }
-        Long currentUserId=authService.getCurrentUserID();
+        Long currentUserId=authService.getCurrentUserIDOptional().orElse(null);
 
         Album album=albumRepository.findById(id).orElseThrow(()->new AlbumNotFoundException(id));
@@ -44 +44 @@
 
     public List<MusicalEntityDto> searchAlbums(String searchTerm){
-        return albumRepository.searchAlbums(authService.getCurrentUserID(), searchTerm);
+        return albumRepository.searchAlbums(authService.getCurrentUserIDOptional().orElse(null), searchTerm);
     }
 

finkwave/src/main/java/com/ukim/finki/develop/finkwave/service/ArtistService.java

@@ -9 +9 @@
 
 import java.util.List;
-import java.util.stream.Collectors;
 
 @Service
 @AllArgsConstructor
 public class ArtistService {
-
     private final ArtistContributionRepository artistContributionRepository;
-    private final AuthService authService;
 
 
     @Transactional(readOnly=true)
-    public List<ArtistContributionDto> getArtistContributions(Long artistId){
-        Long currentUserId=authService.getCurrentUserID();
+    public List<ArtistContributionDto> getArtistContributions(Long artistId, Long currentUserId){
         return artistContributionRepository.findContributionsByArtistId(currentUserId,artistId);
     }

finkwave/src/main/java/com/ukim/finki/develop/finkwave/service/AuthService.java

@@ -5 +5 @@
 import java.nio.file.Path;
 import java.nio.file.Paths;
+import java.util.List;
+import java.util.Optional;
 import java.util.UUID;
 
@@ -123 +125 @@
     }
 
+    public Optional<Long> getCurrentUserIDOptional(){
+        Authentication authentication= SecurityContextHolder.getContext().getAuthentication();
+        if (authentication == null || !authentication.isAuthenticated()) {
+            return Optional.empty();
+        }
+        String username=authentication.getName();
+        return userRepository.findByUsername(username).map(User::getId);
+    }
 
     private User createNonAdminUser(AuthRequestDto authRequestDto) throws IOException {

finkwave/src/main/java/com/ukim/finki/develop/finkwave/service/FollowService.java

@@ -55 +55 @@
         Long id=nonAdminUser.getId();
         List<Follow> followers = followRepository.findFollowersWithProfile(id);
-        Long currentUserId=authService.getCurrentUserID();
+        Long currentUserId=authService.getCurrentUserIDOptional().orElse(null);
 
 

finkwave/src/main/java/com/ukim/finki/develop/finkwave/service/NonAdminUserService.java

@@ -41 +41 @@
     @Transactional(readOnly = true)
     public NonAdminUserDto getNonAdminUserProfile(String username) {
-
-        Long currentUserId= authService.getCurrentUserID();
-
+        Long currentUserId = authService.getCurrentUserIDOptional().orElse(null);
 
         Optional<Artist>artistOptional=artistRepository.findByUsername(username);
@@ -63 +61 @@
 
     private FollowStatusDto getFollowingInfo(Long id,Long currentUserId){
+
         Long followers = followRepository.countByFolloweeId(id);
         Long following = followRepository.countByFollowerId(id);
-        boolean isFollowing = followRepository.isFollowing(currentUserId, id);
+        boolean isFollowing = currentUserId != null && followRepository.isFollowing(currentUserId, id);
         return new FollowStatusDto(isFollowing,followers,following);
     }
@@ -72 +71 @@
         Long artistId=artist.getId();
 
-        List<ArtistContributionDto>artistContributionDtos=artistService.getArtistContributions(artistId);
+        List<ArtistContributionDto>artistContributionDtos=artistService.getArtistContributions(artistId, currentUserId);
         FollowStatusDto followStatusDto=getFollowingInfo(artistId,currentUserId);
 

finkwave/src/main/java/com/ukim/finki/develop/finkwave/service/PlaylistService.java

@@ -35 +35 @@
 
     public PlaylistDto getPlaylist(Long id){
-        Long currentUserId=authService.getCurrentUserID();
+        Long currentUserId=authService.getCurrentUserIDOptional().orElse(null);
         Playlist playlist = playlistRepository.findById(id).orElseThrow(()-> new PlaylistNotFoundException(id));
         List<MusicalEntityDto>songsInPlaylist=songRepository.findSongsByPlaylistId(id,currentUserId);

finkwave/src/main/java/com/ukim/finki/develop/finkwave/service/SongService.java

@@ -27 +27 @@
 
     public List<SongDto> searchSongs(String searchTerm){
-        Long userId = authService.getCurrentUserID();
+        Long userId = authService.getCurrentUserIDOptional().orElse(null);
         return songRepository.searchSongs(userId, searchTerm);
     }
@@ -36 +36 @@
     }
 
-    public MusicalEntityDto getSongById(Long songId){
-        Long userId = null;
-        try {
-            userId = authService.getCurrentUserID();
-        } catch (Exception ignored) {}
-        return songRepository.getSongById(songId, userId);
-    }
+//    public MusicalEntityDto getSongById(Long songId){
+//        Long userId = null;
+//        try {
+//            userId = authService.getCurrentUserID();
+//        } catch (Exception ignored) {}
+//        return songRepository.getSongById(songId, userId);
+//    }
 
     public SongDetailsDto getSongDetails(Long songId){