Changeset 16aed54

Timestamp:

01/27/26 14:40:17 (6 months ago)

Author:

Filip Gavrilovski <filipgavrilovski28@…>

Branches:

main

Children:

c1d2f07

Parents:

3238007

Message:

minor changes with error handling

Files:

• finkwave/src/main/java/com/ukim/finki/develop/finkwave/controller/GlobalExceptionHandler.java (modified) (3 diffs)
• frontend/src/api/axiosInstance.ts (modified) (1 diff)
• frontend/src/pages/Register.tsx (modified) (4 diffs)

finkwave/src/main/java/com/ukim/finki/develop/finkwave/controller/GlobalExceptionHandler.java

@@ -35 +35 @@
     @ExceptionHandler(ResponseStatusException.class)
     public ResponseEntity<Map<String, String>> handleResponseStatusException(ResponseStatusException ex) {
-        logger.error("Response status:", ex);
+        logger.error("Response status error: {}", ex.getMessage());
         return ResponseEntity
                 .status(ex.getStatusCode())
@@ -43 +43 @@
     @ExceptionHandler(MaxUploadSizeExceededException.class)
     public ResponseEntity<Map<String, Object>> handleMaxSize(MaxUploadSizeExceededException ex) {
-        logger.error("Max upload size error:", ex);
+        logger.error("Max upload size error: {}", ex.getMessage());
         return ResponseEntity
                 .status(HttpStatus.PAYLOAD_TOO_LARGE)
@@ -54 +54 @@
     @ExceptionHandler(Exception.class)
     public ResponseEntity<Map<String, String>> handleGenericException(Exception ex) {
-        logger.error("Unexpected error occurred:", ex);
+        logger.error("Unexpected error occurred: {}", ex.getMessage());
         return ResponseEntity
                 .status(HttpStatus.INTERNAL_SERVER_ERROR)

frontend/src/api/axiosInstance.ts

@@ -70 +70 @@
                         [401, 403].includes(error.response?.status) &&
                         !originalConfig._retry &&
-                        originalConfig.url !== "/auth/refresh"
+                        originalConfig.url !== "/auth/refresh" &&
+                        originalConfig.url !== "/auth/login" &&
+                        originalConfig.url !== "/auth/register"
                 ) {
                         originalConfig._retry = true;

frontend/src/pages/Register.tsx

@@ -28 +28 @@
         }, [previewProfilePhoto]);
 
+        const handleRemoveFile = () => {
+                if (previewProfilePhoto) {
+                        URL.revokeObjectURL(previewProfilePhoto);
+                }
+                setProfilePhotoFile(null);
+                setPreviewProfilePhoto(null);
+        };
+
         const handleRegister = async (e: React.FormEvent) => {
                 e.preventDefault();
                 if (profilePhotoFile && profilePhotoFile.size > 5 * 1024 * 1024) {
                         alert("Max file size is 5MB");
+                        return;
+                }
+
+                if (username === "" || password === "" || fullname === "" || email === "") {
+                        setError("Please fill in all required fields.");
                         return;
                 }
@@ -56 +69 @@
                         toast.success("Registration successful!");
                 } catch (error: any) {
-                        const errorMessage =
-                                error.response?.data?.error || "Registration failed. Please try again.";
+                        const errorMessage = error.response?.data?.error || "Please try again.";
                         setError(`Registration failed: ${errorMessage}`);
                 }
@@ -65 +77 @@
                 <div className="flex flex-col items-center justify-center min-h-[90vh] bg-gray-100">
                         <h2 className="text-2xl mb-4">Register</h2>
-                        <form className="bg-white p-6 rounded shadow-md w-80">
+                        <form className="bg-white p-6 rounded shadow-md w-full max-w-md">
                                 {error && <p className="text-red-500 mb-4">{error}</p>}
                                 <div className="mb-4">
@@ -120 +132 @@
                                                 <label
                                                         htmlFor="profilePhoto"
-                                                        className="px-4 py-2 bg-blue-500 text-white rounded cursor-pointer hover:bg-blue-600 transition-colors text-sm font-medium"
+                                                        className="px-4 py-2 bg-blue-500 text-white rounded cursor-pointer hover:bg-blue-600 transition-colors text-sm font-medium text-center"
                                                 >
                                                         Choose File
                                                 </label>
-                                                <span className="text-gray-600 text-sm">
+                                                <span className="text-gray-600 text-sm flex-1">
                                                         {profilePhotoFile ? profilePhotoFile.name : "No file chosen"}
                                                 </span>
+                                                {profilePhotoFile && (
+                                                        <button
+                                                                type="button"
+                                                                onClick={handleRemoveFile}
+                                                                className="px-3 py-2 bg-red-500 text-white rounded hover:bg-red-600 transition-colors text-sm font-medium"
+                                                        >
+                                                                Remove
+                                                        </button>
+                                                )}
                                         </div>
                                         <input