Changeset 5c65932

Timestamp:

01/26/26 13:35:45 (6 months ago)

Author:

Filip Gavrilovski <filipgavrilovski28@…>

Branches:

main

Children:

0c86e77

Parents:

ecd0016

Message:

auth clean up and covering todo-s

Location:

finkwave/src/main/java/com/ukim/finki/develop/finkwave

Files:

• model/NonAdminUser.java (modified) (2 diffs)
• model/User.java (modified) (2 diffs)
• service/AuthService.java (modified) (5 diffs)
• service/CustomUserDetailsService.java (modified) (1 diff)

finkwave/src/main/java/com/ukim/finki/develop/finkwave/model/NonAdminUser.java

@@ -4 +4 @@
 import lombok.Getter;
 import lombok.Setter;
+import org.hibernate.annotations.Cascade;
 
 @Getter
@@ -15 +16 @@
 
     @MapsId
-    @OneToOne
+    @OneToOne(cascade = {CascadeType.PERSIST, CascadeType.MERGE})
     @JoinColumn(name = "user_id")
     private User user;

finkwave/src/main/java/com/ukim/finki/develop/finkwave/model/User.java

@@ -4 +4 @@
 import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
 
-import jakarta.persistence.*;
-import lombok.*;
+import jakarta.persistence.Column;
+import jakarta.persistence.Entity;
+import jakarta.persistence.EnumType;
+import jakarta.persistence.Enumerated;
+import jakarta.persistence.GeneratedValue;
+import jakarta.persistence.GenerationType;
+import jakarta.persistence.Id;
+import jakarta.persistence.OneToOne;
+import jakarta.persistence.Table;
+import lombok.AllArgsConstructor;
+import lombok.Builder;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+import lombok.Setter;
 
 @Setter
@@ -41 +53 @@
     private Admin admin;
 
-    // todo: is this column needed? if so, add to entities and documentation
     @Enumerated(EnumType.STRING)
     private Role role;
 
-    @OneToOne(mappedBy = "user")
+    @OneToOne(mappedBy = "user", orphanRemoval = true)
     @JsonIgnore
     private NonAdminUser nonAdminUser;

finkwave/src/main/java/com/ukim/finki/develop/finkwave/service/AuthService.java

@@ -1 +1 @@
 package com.ukim.finki.develop.finkwave.service;
 
-import com.ukim.finki.develop.finkwave.config.AuthProperties;
-import com.ukim.finki.develop.finkwave.dto.LoginRequestDto;
 import org.springframework.security.crypto.password.PasswordEncoder;
 import org.springframework.stereotype.Service;
 
+import com.ukim.finki.develop.finkwave.config.AuthProperties;
 import com.ukim.finki.develop.finkwave.dto.AuthRequestDto;
+import com.ukim.finki.develop.finkwave.dto.LoginRequestDto;
 import com.ukim.finki.develop.finkwave.dto.UserResponseDto;
 import com.ukim.finki.develop.finkwave.model.NonAdminUser;
@@ -17 +17 @@
 import jakarta.servlet.http.Cookie;
 import jakarta.servlet.http.HttpServletResponse;
+import jakarta.transaction.Transactional;
 import lombok.RequiredArgsConstructor;
 
@@ -30 +31 @@
 
 
+    @Transactional
     public UserResponseDto registerAndLogIn(HttpServletResponse response, AuthRequestDto authRequestDto){
         if (userRepository.findByUsername(authRequestDto.username()).isPresent()){
             throw new RuntimeException("User already exists");
         }
-        createNonAdminUser(authRequestDto);
-        // todo: could also be redirect in controller, which one is better?
-        return login(response, new LoginRequestDto(authRequestDto.username(), authRequestDto.password()));
+        User user = createNonAdminUser(authRequestDto);
+        return authenticateAndRespond(response, user);
     }
 
-    // todo: dto in arguments or the standalone values?
     public UserResponseDto login(HttpServletResponse response, LoginRequestDto loginRequestDto){
         User user = userRepository.findByUsername(loginRequestDto.username())
                 .orElseThrow(() -> new RuntimeException("Invalid credentials"));
+
         if (!passwordEncoder.matches(loginRequestDto.password(), user.getPassword())){
             throw new RuntimeException("Invalid credentials");
         }
 
-        String accessToken = jwtService.generateToken(loginRequestDto.username(), user.getRole().name());
-        RefreshToken refreshToken = refreshTokenService.createRefreshToken(user);
-
-        UserResponseDto userResponseDto = new UserResponseDto(user.getUsername(), user.getRole());
-        addTokensToResponse(response, refreshToken, accessToken);
-        return userResponseDto;
+        return authenticateAndRespond(response, user);
     }
 
@@ -93 +89 @@
     }
 
-    // todo: should it be transactional?
-//    @Transactional
-    private void createNonAdminUser(AuthRequestDto authRequestDto){
+    private User createNonAdminUser(AuthRequestDto authRequestDto){
         User user = User.builder()
                 .fullName(authRequestDto.fullname())
@@ -109 +103 @@
         user.setNonAdminUser(nonAdminUser);
         nonAdminUserRepository.save(nonAdminUser);
-        userRepository.save(user);
+        return user;
+    }
+
+    private UserResponseDto authenticateAndRespond(HttpServletResponse response, User user){
+        String accessToken = jwtService.generateToken(user.getUsername(), user.getRole().name());
+        RefreshToken refreshToken = refreshTokenService.createRefreshToken(user);
+
+        UserResponseDto userResponseDto = new UserResponseDto(user.getUsername(), user.getRole());
+        addTokensToResponse(response, refreshToken, accessToken);
+        return userResponseDto;
     }
 

finkwave/src/main/java/com/ukim/finki/develop/finkwave/service/CustomUserDetailsService.java

@@ -22 +22 @@
         User user = userRepository.findByUsername(username)
                 .orElseThrow(() -> new RuntimeException("user not found"));
-        // todo: fix hardcoded role
-        // List<GrantedAuthority> authorities = List.of(new SimpleGrantedAuthority("ROLE_" + user.getRole().name()));
-        List<GrantedAuthority> authorities = List.of(new SimpleGrantedAuthority("ROLE_NONADMIN"));
+         List<GrantedAuthority> authorities = List.of(new SimpleGrantedAuthority("ROLE_" + user.getRole().name()));
         return new org.springframework.security.core.userdetails.User(
                 user.getUsername(),