Changeset 62acea2

Timestamp:

01/26/26 12:25:25 (6 months ago)

Author:

Filip Gavrilovski <filipgavrilovski28@…>

Branches:

main

Children:

335fee0

Parents:

561e9a6

Message:

small refactor: extract helpers in auth service

Location:

finkwave/src/main/java/com/ukim/finki/develop/finkwave

Files:

• model/User.java (modified) (1 diff)
• service/AuthService.java (modified) (3 diffs)

finkwave/src/main/java/com/ukim/finki/develop/finkwave/model/User.java

@@ -5 +5 @@
 
 import jakarta.persistence.*;
-import lombok.Getter;
-import lombok.NoArgsConstructor;
-import lombok.Setter;
+import lombok.*;
 
 @Setter
 @Getter
 @Entity
+@Builder
 @NoArgsConstructor
+@AllArgsConstructor
 @Table(name = "users")
 @JsonIgnoreProperties({"hibernateLazyInitializer", "handler"})

finkwave/src/main/java/com/ukim/finki/develop/finkwave/service/AuthService.java

@@ -29 +29 @@
     private final int refreshTokenMaxAge = 10 * 24 * 60 * 60;
 
-    // todo: should it be transactional?
-//    @Transactional
+
     public UserResponseDto registerAndLogIn(HttpServletResponse response, AuthRequestDto authRequestDto){
         if (userRepository.findByUsername(authRequestDto.username()).isPresent()){
             throw new RuntimeException("User already exists");
         }
-        User user = new User();
-
-        // todo: builder / private createUser method
-        user.setUsername(authRequestDto.username());
-        user.setRole(Role.NONADMIN);
-        user.setFullName(authRequestDto.fullname());
-        user.setProfilePhoto(authRequestDto.profilePhoto());
-        user.setEmail(authRequestDto.email());
-        user.setPassword(passwordEncoder.encode(authRequestDto.password()));
-        NonAdminUser nonAdminUser = new NonAdminUser();
-        nonAdminUser.setUser(user);
-        user.setNonAdminUser(nonAdminUser);
-        nonAdminUserRepository.save(nonAdminUser);
-        userRepository.save(user);
+        createNonAdminUser(authRequestDto);
         // todo: could also be redirect in controller, which one is better?
-        return login(response, new LoginRequestDto(user.getUsername(), authRequestDto.password()));
+        return login(response, new LoginRequestDto(authRequestDto.username(), authRequestDto.password()));
     }
-
 
     // todo: dto in arguments or the standalone values?
@@ -103 +88 @@
         if (refreshToken != null){
             invalidateRefreshToken(refreshToken);
-            Cookie clearCookie = new Cookie("refreshToken", null);
-            clearCookie.setHttpOnly(true);
-            clearCookie.setSecure(false);
-            clearCookie.setPath("/");
-            clearCookie.setMaxAge(0);
-            httpServletResponse.addCookie(clearCookie);
+            clearCookieByName(httpServletResponse, "refreshToken");
         }
+        clearCookieByName(httpServletResponse, "accessToken");
+    }
 
-        Cookie clearAccess = new Cookie("accessToken", null);
+    // todo: should it be transactional?
+//    @Transactional
+    private void createNonAdminUser(AuthRequestDto authRequestDto){
+        User user = User.builder()
+                .fullName(authRequestDto.fullname())
+                .username(authRequestDto.username())
+                .email(authRequestDto.email())
+                .profilePhoto(authRequestDto.profilePhoto())
+                .password(passwordEncoder.encode(authRequestDto.password()))
+                .role(Role.NONADMIN)
+                .build();
+
+        NonAdminUser nonAdminUser = new NonAdminUser();
+        nonAdminUser.setUser(user);
+        user.setNonAdminUser(nonAdminUser);
+        nonAdminUserRepository.save(nonAdminUser);
+        userRepository.save(user);
+    }
+
+    private void clearCookieByName(HttpServletResponse response, String cookieName){
+        Cookie clearAccess = new Cookie(cookieName, null);
         clearAccess.setHttpOnly(true);
         clearAccess.setSecure(false);
         clearAccess.setPath("/");
         clearAccess.setMaxAge(0);
-        httpServletResponse.addCookie(clearAccess);
+        response.addCookie(clearAccess);
     }
 
@@ -122 +124 @@
     private void addTokensToResponse(HttpServletResponse response, RefreshToken refreshToken, String accessToken){
         Cookie refreshCookie = new Cookie("refreshToken", refreshToken.getToken());
+        refreshCookie.setHttpOnly(true);
         refreshCookie.setSecure(false);
-        refreshCookie.setHttpOnly(true);
         refreshCookie.setPath("/");
         refreshCookie.setMaxAge(refreshTokenMaxAge);