Changeset c42181c for iknow-api

Timestamp:

09/16/26 14:48:55 (7 days ago)

Author:

Stefan-Saveski <stefansaveski19@…>

Branches:

master

Children:

8ee90bd

Parents:

ea40556

Message:

Refactor payment model to remove redundant user_id, addressing BCNF violation in Phase 5 normalization

Location:

iknow-api

Files:

• Data/AppDbContext.cs (modified) (1 diff)
• Models/Payment.cs (modified) (1 diff)
• Models/User.cs (modified) (1 diff)

iknow-api/Data/AppDbContext.cs

@@ -290 +290 @@
                 e.HasKey(p => p.Id);
                 e.Property(p => p.Id).HasColumnName("id");
-                e.Property(p => p.UserId).HasColumnName("user_id");
                 e.Property(p => p.EnrollmentInfoId).HasColumnName("enrollment_id");
                 e.Property(p => p.Amount).HasColumnName("amount");
 
-                e.HasOne(p => p.User)
-                 .WithMany(u => u.Payments)
-                 .HasForeignKey(p => p.UserId)
-                 .OnDelete(DeleteBehavior.Cascade);
-
+                // No user_id: the student comes from the enrolment. Removing it
+                // was the BCNF fix from Phase 5 (enrolled_id -> user_id).
                 e.HasOne(p => p.EnrolledSemesters)
                  .WithMany(es => es.Users)

iknow-api/Models/Payment.cs

@@ -1 @@
-using System.ComponentModel.DataAnnotations.Schema;
-
 namespace iknow_api.Models
 {
+    /// <summary>
+    /// The student is reached through the enrolment: enrolled_id -> user_id.
+    /// A user_id here would be redundant and could contradict the enrolment,
+    /// which is the BCNF violation found during normalization (Phase 5).
+    /// </summary>
     public class Payment
     {
         public int Id { get; set; }
 
-        public int UserId { get; set; }
-        public User? User { get; set; }
         public int EnrollmentInfoId { get; set; }
         public int Amount { get; set; }
         public EnrolledSemesters? EnrolledSemesters { get; set; }
-
     }
 }

iknow-api/Models/User.cs

@@ -28 +28 @@
         public ICollection<UserDocuments>? Documents { get; set; }
 
-        // Named for the relationship it carries: Users 1 --pays-- N Payment.
-        public ICollection<Payment>? Payments { get; set; }
-
         // Users 1 --submits-- N EnrolledSemesters
         public ICollection<EnrolledSemesters>? Enrolments { get; set; }