Index: app/Http/Controllers/GenericModelController.php =================================================================== --- app/Http/Controllers/GenericModelController.php (revision 93774cc2874f890ea669f15b97fa469770024559) +++ app/Http/Controllers/GenericModelController.php (revision 93774cc2874f890ea669f15b97fa469770024559) @@ -0,0 +1,127 @@ +getModelClass($model); + if (!$modelClass) { + abort(404, 'Model not found.'); + } + + $query = $modelClass::query(); + $modelInstance = new $modelClass(); + $fillable = $modelInstance->getFillable(); + + // Add search functionality + if ($request->has('search') && $request->search) { + $query->where(function ($q) use ($request, $fillable) { + foreach ($fillable as $field) { + $q->orWhere($field, 'like', '%' . $request->search . '%'); + } + }); + } + + // Add sorting + $sortBy = $request->get('sort_by', 'created_at'); + $sortDirection = $request->get('sort_direction', 'desc'); + $query->orderBy($sortBy, $sortDirection); + + // Paginate results + $items = $query->paginate( + perPage: $request->get('per_page', 10), + page: $request->get('page', 1) + )->withQueryString(); + + return Inertia::render('GenericModelPage', [ + 'model' => Str::singular(Str::studly($model)), + 'items' => $items, + 'filters' => [ + 'search' => $request->search, + 'sort_by' => $sortBy, + 'sort_direction' => $sortDirection, + 'per_page' => $request->get('per_page', 10) + ] + ]); + } + + /** + * Store a newly created resource in storage. + */ + public function store(Request $request, string $model) + { + $modelClass = $this->getModelClass($model); + if (!$modelClass) { + abort(404, 'Model not found.'); + } + + $modelInstance = new $modelClass(); + $fillable = $modelInstance->getFillable(); + + // Dynamically get validation rules from a method on the model + $validated = $request->validate($modelClass::getValidationRules()); + + $modelClass::create($validated); + + return redirect()->route('generic.index', ['model' => Str::plural($model)]) + ->with('success', Str::singular($model) . ' created successfully.'); + } + + /** + * Update the specified resource in storage. + */ + public function update(Request $request, string $model, string $id) + { + $modelClass = $this->getModelClass($model); + if (!$modelClass) { + abort(404, 'Model not found.'); + } + + $item = $modelClass::findOrFail($id); + + $validated = $request->validate($modelClass::getValidationRules($item->id)); + + $item->update($validated); + + return redirect()->route('generic.index', ['model' => Str::plural($model)]) + ->with('success', Str::singular($model) . ' updated successfully.'); + } + + /** + * Remove the specified resource from storage. + */ + public function destroy(string $model, string $id) + { + $modelClass = $this->getModelClass($model); + if (!$modelClass) { + abort(404, 'Model not found.'); + } + + $item = $modelClass::findOrFail($id); + $item->delete(); + + return redirect()->route('generic.index', ['model' => Str::plural($model)]) + ->with('success', Str::singular($model) . ' deleted successfully.'); + } + + /** + * Helper to resolve the model class. + */ + protected function getModelClass(string $model) + { + $modelClass = 'App\\Models\\' . Str::studly(Str::singular($model)); + if (class_exists($modelClass)) { + return $modelClass; + } + return null; + } +} Index: app/Models/Client.php =================================================================== --- app/Models/Client.php (revision 493b218696760be36468e7a224861a03e0952211) +++ app/Models/Client.php (revision 93774cc2874f890ea669f15b97fa469770024559) @@ -27,4 +27,18 @@ ]; + public static function getValidationRules($id = null): array + { + return [ + 'client_name' => 'required|string|max:255', + 'country' => 'required|string|max:255', + 'registration_number' => 'nullable|string|max:255', + 'tax_id' => 'nullable|string|max:255', + 'contact_person' => 'nullable|string|max:255', + 'phone_number' => 'nullable|string|max:255', + 'billing_address' => 'nullable|string', + 'shipping_address' => 'nullable|string', + ]; + } + // Orders where this company is the buyer public function buyerOrders(): HasMany Index: resources/js/Layout/App.vue =================================================================== --- resources/js/Layout/App.vue (revision 493b218696760be36468e7a224861a03e0952211) +++ resources/js/Layout/App.vue (revision 93774cc2874f890ea669f15b97fa469770024559) @@ -1,15 +1,18 @@ -Looking at your Laravel routes and the current App.vue file, I can see that you're using Inertia.js with Laravel routes. The issue with URL resolution is that we need to use the `route()` helper function from Ziggy to properly resolve Laravel named routes. - -**Refactoring Description:** -I'll apply **Extract Variable** and **Extract Method** refactorings by: -- Creating a computed property for navigation items that uses Laravel route names -- Extracting the common link class logic into a reusable method -- Removing code duplication while maintaining the same functionality - -```vue template -``` - - -The refactoring eliminates code duplication by: -1. Using the `route()` helper to properly generate Laravel route URLs -2. Creating a `navigationItems` computed property that centralizes navigation configuration -3. Extracting the link class logic into a reusable `getLinkClasses` method -4. Using `v-for` loops to render navigation items dynamically -5. Improving active state detection using Inertia's page component information Index: sources/js/Pages/Client.vue =================================================================== --- resources/js/Pages/Client.vue (revision 493b218696760be36468e7a224861a03e0952211) +++ (revision ) @@ -1,478 +1,0 @@ - - -