Changeset 98f448a for sources/app/src/main/java/parkup/services

Timestamp:

02/02/22 19:35:14 (2 years ago)

Author:

andrejTavchioski <andrej.tavchioski@…>

Branches:

master

Children:

80ddcae, c71fa06

Parents:

df4089c

Message:

parkingZone and parkingSession services fix

Location:

sources/app/src/main/java/parkup/services

Files:

• AdministratorService.java (modified) (2 diffs)
• ParkingSessionService.java (modified) (2 diffs)
• ParkingZoneService.java (modified) (4 diffs)
• WorkerService.java (modified) (3 diffs)

sources/app/src/main/java/parkup/services/AdministratorService.java

@@ -5 +5 @@
 import java.util.Optional;
 import java.util.UUID;
+import java.util.stream.Collectors;
 import javax.transaction.Transactional;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -59 +60 @@
         if (administratorOpt.isPresent()) {
             Administrator administratorNov = this.administratorRepository.findByAdministratorId(administratorId);
-            if (email != null && email.length() > 1 && email.contains("@") && !Objects.equals(administratorNov.getEmail(), email)) {
-                Optional<Administrator> userOpt1 = this.administratorRepository.findAdministratorByEmail(email);
-                if (userOpt1.isPresent()) {
-                    throw new IllegalStateException("email taken");
-                }
-                administratorNov.setEmail(email);
+            if (email != null && email.length() > 1 && email.contains("@")) {
+                List<String> emails = administratorRepository.findAll().stream().map(Administrator::getEmail).collect(Collectors.toList());
+                for(String mailToCheck :emails)
+                    if (email.equals(mailToCheck) && administratorNov.getAdministratorId()!=administratorId) {
+                        throw new IllegalStateException("email taken");
+                    }
             }else{
                 throw new IllegalStateException("email not valid");

sources/app/src/main/java/parkup/services/ParkingSessionService.java

@@ -49 +49 @@
     }
 
-   /* @Transactional
-    public void updateParkingSession(int parkingSessionId, String timeStart, String timeEnd, Tablicka tablicka) {
-        Optional<ParkingSession> parkingSessionOpt = Optional.ofNullable(parkingSessionRepository.findByPssId(parkingSessionId));
-        if (parkingSessionOpt.isPresent()) {
-            ParkingSession parkingSessionNov = parkingSessionRepository.findByPssId(parkingSessionId);
-
-            if(!parkingSessionNov.getTimeStart().equals(timeStart) && !parkingSessionNov.getTimeStart().equals(timeEnd))
-                parkingSessionNov.setTimeStart(timeStart);
-
-            if(!parkingSessionNov.getTimeEnd().equals(timeEnd) && !parkingSessionNov.getTimeEnd().equals(timeStart))
-                parkingSessionNov.setTimeEnd(timeEnd);
-
-            if(tablicka!=null && !Objects.equals(parkingSessionNov.getTablica(),tablicka)){
-                parkingSessionNov.setTablica(tablicka);
-            }
-        }else{
-            throw new IllegalStateException("The ParkingSession does not exist");
-        }
-    }*/
     @Transactional
     public Optional<ParkingSession> deleteParkingSession(int parkingSessionId) {
@@ -156 +137 @@
         String expYearString=date.split("/")[1];
         if(expMonthString.startsWith("0"))
-            expMonthString=expYearString.substring(1);
+            expMonthString=expMonthString.substring(1);
         if(expYearString.startsWith("0"))
             expYearString=expYearString.substring(1);

sources/app/src/main/java/parkup/services/ParkingZoneService.java

@@ -91 +91 @@
 
         //TODO prati niza od objekti ParkingSpaces i prati objekt ParkingZoneLocation
-
+        ParkingZone parkingZone = parkingZoneRepository.findByPzId(parkingZoneId);
             ParkingZone parkingZoneNov = parkingZoneRepository.findByPzId(parkingZoneId);
             if (parkingZoneNov!=null) {
@@ -132 +132 @@
                         parkingZoneNov.getParkingSpaces().add(ps);
                     }
+                }else{
+                    parkingZoneNov.setParkingSpaces(null);
                 }
                 if (!responsibleWorkers.isEmpty()) {
-                    ParkingZone parkingZone = parkingZoneRepository.findByPzId(parkingZoneId);
+
+                    for(Integer workerId: getResponsibleWorkers(parkingZoneId).stream().map(WorkerDemo::getWorkerId).collect(Collectors.toList())){
+                        workerRepository.findByWorkerId(workerId).getParkingZones().remove(parkingZone);
+                    }
                     for (Integer workerId : responsibleWorkers.stream().map(WorkerDemo::getWorkerId).collect(Collectors.toList())) {
                         Worker workerToAdd = workerRepository.findByWorkerId(workerId);
@@ -140 +145 @@
                         workerToAdd.getParkingZones().add(parkingZone);
                     }
+                }else{
+                    workerRepository.findAll().stream().filter(w->w.getParkingZones().contains(parkingZone)).forEach(w->w.getParkingZones().remove(parkingZone));
                 }
 
@@ -156 +163 @@
                 parkingZoneOpt.get().setParkingSpaces(null);
                 parkingZoneOpt.get().setParkingZoneLocation(null);
+                workerRepository.findAll().stream().filter(w->w.getParkingZones().contains(parkingZoneOpt.get())).forEach(w->w.getParkingZones().remove(parkingZoneOpt.get()));
                 parkingZoneRepository.deleteByPzId(parkingZoneId);
             } else {

sources/app/src/main/java/parkup/services/WorkerService.java

@@ -31 +31 @@
     }
 
-    public List<WorkerDemo> getWorkers() {
-        return this.workerRepository.findAll().stream().map(WorkerDemo::new).collect(Collectors.toList());
+    public List<Worker> getWorkers() {
+        return this.workerRepository.findAll();
     }
 
     public WorkerDemoParkingZones findById(int workerId) {
         Worker worker = this.workerRepository.findByWorkerId(workerId);
-        WorkerDemoParkingZones workerToReturn = new WorkerDemoParkingZones(worker);
-        return workerToReturn;
+        return new WorkerDemoParkingZones(worker);
     }
 
@@ -103 +102 @@
         Optional<Worker> workerOpt = Optional.ofNullable(this.workerRepository.findByWorkerId(workerId));
         if (workerOpt.isPresent()) {
-
             if (email != null && email.length() > 1 && email.contains("@") ) {
                 List<String> emails = workerRepository.findAll().stream().map(Worker::getEmail).collect(Collectors.toList());
@@ -117 +115 @@
                 workerOpt.get().setPassword(bCryptPasswordEncoder.encode(password));
             }
-            workerOpt.get().setLocked(locked);
+            workerOpt.get().setAccount(locked);
 
             if (firstName != null && firstName.length() > 1 && !Objects.equals(workerOpt.get().getFirstName(), firstName)) {