Changeset 83fb5e2 for database/drizzle/queries/builds.ts

Timestamp:

12/25/25 01:49:51 (7 months ago)

Author:

Tome <gjorgievtome@…>

Branches:

main

Children:

e7f1bfa

Parents:

d4842f4

Message:

fix returns and add checks

File:

• database/drizzle/queries/builds.ts (modified) (12 diffs)

database/drizzle/queries/builds.ts

@@ -46 +46 @@
 
 export async function setBuildApprovalStatus(db: Database, buildId: number, isApproved: boolean){
-    const result = await db
+    const [result] = await db
         .update(buildsTable)
         .set({
@@ -61 +61 @@
         })
 
-    return result.length;
+    return result?.id ?? null;
 }
 
@@ -135 +135 @@
             created_at: buildsTable.createdAt,
             total_price: buildsTable.totalPrice,
-            avgRating: sql<number>`AVG(${ratingBuildsTable.value}::float)`
+            avgRating: sql<number>`COALESCE(AVG(${ratingBuildsTable.value}::float),0)`
         })
         .from(buildsTable)
@@ -160 +160 @@
 
     return approvedBuildsList;
-}
-
-export async function getHighestRankedBuilds(db: Database, limit? : number) {
-    const highestRankedBuildsList = await db
-        .select({
-            id: buildsTable.id,
-            user_id: buildsTable.userId,
-            name: buildsTable.name,
-            created_at: buildsTable.createdAt,
-            total_price: buildsTable.totalPrice,
-            avgRating: sql<number>`AVG(${ratingBuildsTable.value}::float)`
-        })
-        .from(buildsTable)
-        .innerJoin(
-            ratingBuildsTable,
-            eq(buildsTable.id, ratingBuildsTable.buildId)
-        )
-        .where(
-            eq(buildsTable.isApproved, true)
-        )
-        .groupBy(buildsTable.id)
-        .orderBy(
-            desc(sql<number>`AVG(${ratingBuildsTable.value}::float)`)
-        )
-        .limit(limit || 100); // 100 placeholder
-
-    return highestRankedBuildsList;
 }
 
@@ -335 +308 @@
         .limit(1);
 
-    if (existing.length) {
+    if (existing.length > 0) {
         await db
             .delete(favoriteBuildsTable)
@@ -345 +318 @@
             );
 
-        return { favorite: false };
+        return null;
     }
 
@@ -355 +328 @@
         });
 
-    return { favorite: true };
+    return true;
 }
 
@@ -378 +351 @@
         })
 
-    return result;
+    return result ?? null;
 }
 
@@ -404 +377 @@
         })
 
-    return result;
+    return result ?? null;
 }
 
@@ -498 +471 @@
 
 export async function deleteBuild(db: Database, userId: number, buildId: number) {
-    const result = await db
+    const [result] = await db
         .delete(buildsTable)
         .where(
@@ -510 +483 @@
         })
 
-    return result.length;
+    return result?.id ?? null;
 }
 
@@ -550 +523 @@
         }
 
-        return newBuild.id;
+        return newBuild?.id ?? null;
     });
 }