Changeset 7bc8942 in Git

Timestamp:

01/16/22 16:46:28 (3 years ago)

Author:

Petar Partaloski <ppartaloski@…>

Branches:

main

Children:

7fafead

Parents:

2a5d6a3

Message:

Fixed password encoding

Location:

src/main/java/com/wediscussmovies/project

Files:

• service/impl/UserServiceImpl.java (modified) (3 diffs)
• web/controller/UserController.java (modified) (4 diffs)

src/main/java/com/wediscussmovies/project/service/impl/UserServiceImpl.java

@@ -1 +1 @@
 package com.wediscussmovies.project.service.impl;
 
+import com.wediscussmovies.project.model.PasswordEncoder;
 import com.wediscussmovies.project.model.User;
 import com.wediscussmovies.project.model.exception.PasswordsDontMatchException;
@@ -11 +12 @@
 
 import javax.servlet.http.HttpServletRequest;
+import java.security.NoSuchAlgorithmException;
 import java.util.Optional;
 
@@ -42 +44 @@
             return Optional.empty();
         }
-            if(userRepository.findByUsername(username).isPresent()){
+        if(userRepository.findByUsername(username).isPresent()){
             request.getSession().setAttribute("error", new UserWithUsernameAlreadyExists(username).getMessage());
             return Optional.empty();

src/main/java/com/wediscussmovies/project/web/controller/UserController.java

@@ -1 +1 @@
 package com.wediscussmovies.project.web.controller;
 
+import com.wediscussmovies.project.model.PasswordEncoder;
 import com.wediscussmovies.project.model.User;
 import com.wediscussmovies.project.model.exception.InvalidUserCredentialsException;
@@ -12 +13 @@
 
 import javax.servlet.http.HttpServletRequest;
+import java.security.NoSuchAlgorithmException;
 import java.util.Optional;
 
@@ -24 +26 @@
 
     @GetMapping("/login")
-    public String getLoginPage(){
-       return "login";
+    public String getLoginPage(Model model){
+        return "login";
     }
 
     @PostMapping("/login/confirm")
-    public String confirmLogin(HttpServletRequest request, Model model){
+    public String confirmLogin(HttpServletRequest request, Model model,
+                               @RequestParam String username,
+                               @RequestParam String password){
         Optional<User> user;
         try{
-            user = this.userService.login(request.getParameter("username"), request.getParameter("password"));
+            password = PasswordEncoder.getEncodedPasswordString(password);
+        }
+        catch (NoSuchAlgorithmException ex){
+            model.addAttribute("hasError", true);
+            model.addAttribute("error", ex.getMessage());
+            return "login";
+        }
+
+        try{
+            user = this.userService.login(username, password);
             request.getSession().setAttribute("user", user);
             request.getSession().setAttribute("loggedIn",true);
@@ -58 +71 @@
                                   @RequestParam String surname){
         Optional<User> user;
+
+        try{
+            password = PasswordEncoder.getEncodedPasswordString(password);
+            confirmPassword = PasswordEncoder.getEncodedPasswordString(confirmPassword);
+        }
+        catch (NoSuchAlgorithmException ex){
+            request.getSession().setAttribute("error", "Contact the administrators!");
+            request.getSession().setAttribute("hasError", "true");
+            return "redirect:/movies";
+        }
+
         user = this.userService.register(request, email, password, confirmPassword, username, name, surname);
         if(user.isEmpty()){
             request.setAttribute("hasError", "true");
         }else{
-            request.setAttribute("hasError", "false");
+            request.getSession().setAttribute("hasError", "false");
+            request.getSession().setAttribute("user", user.get());
+            request.getSession().setAttribute("loggedIn",true);
         }
-        request.getSession().setAttribute("user", user.get());
-        request.getSession().setAttribute("loggedIn",true);
         return "redirect:/movies";
     }